Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Added serialization for IncrementalPCA #1926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ENH: Added serialization for IncrementalPCA #1926

wants to merge 2 commits into from

Conversation

olegkkruglov
Copy link
Contributor

Description

  • Contains changes from ENH: Renamed layout check macro for np.array, changed default layout for oneDAL table #1924 which are necessary for correctly working multiple times serialization/deserialization
  • Added __getstate__ and __setstate__ methods to IncrementalPCA
  • Finalization is called with serialization during __getstate__ method
  • _need_to_finalize flag is added to avoid unnecessary call of finalization backend.
  • Added test for checking if it works well
  • Updated deselected_tests.yaml
  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes, if necessary.
  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.
  • I have resolved any merge conflicts that might occur with the base branch.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details)
  • I have added a respective label(s) to PR if I have a permission for that.

@olegkkruglov olegkkruglov added the enhancement New feature or request label Jul 10, 2024
@olegkkruglov
Copy link
Contributor Author

/intelci: run

@olegkkruglov
Copy link
Contributor Author

/intelci: run

@olegkkruglov olegkkruglov force-pushed the incpca-pickle branch 2 times, most recently from 926af7c to c294007 Compare July 15, 2024 09:40
@samir-nasibli
Copy link
Contributor

@olegkkruglov is this PR on development? what is the status for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samir-nasibli samir-nasibli samir-nasibli left review comments

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@icfaust icfaust Awaiting requested review from icfaust icfaust is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegkkruglov @samir-nasibli