-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: functional support for Array API #1861
Merged
samir-nasibli
merged 105 commits into
intel:main
from
samir-nasibli:enh/functional_array_api
Sep 10, 2024
Merged
Changes from 97 commits
Commits
Show all changes
105 commits
Select commit
Hold shift + click to select a range
bec3ebb
BUG: fixing circular import in daal4py/sklearnex device_offloading
samir-nasibli 9052a73
removed onedal4py sklearnex dependence
samir-nasibli b070c89
minor fix
samir-nasibli 0fbc680
Merge branch 'intel:main' into fix/device_offload
samir-nasibli 8a6c4da
Merge branch 'intel:main' into fix/device_offload
samir-nasibli 89ac903
Merge branch 'intel:main' into fix/device_offload
samir-nasibli 01d73da
minor update
samir-nasibli d4587aa
Merge branch 'intel:main' into fix/device_offload
samir-nasibli b5f8921
added daal4py.sklearn._config for exposing sklearnex settings
samir-nasibli 46dea79
Merge branch 'intel:main' into fix/device_offload
samir-nasibli 8ce81ea
removed daal4py device_offloading
samir-nasibli fc01bae
integrating changes of device offloading for sklearnex primitives/est…
samir-nasibli 18e6599
minor fixes
samir-nasibli 4318064
minor fix for daal4py/sklearn/linear_model/_coordinate_descent.py
samir-nasibli 864c1a1
minor fix for daal4py/sklearn/linear_model/_linear.py
samir-nasibli 4142bf1
fix for sklearnex/_device_offload.py
samir-nasibli 25d87bc
fix for onedal._config
samir-nasibli 778b88d
wrapping daal4py.sklearne Kmeans with onedal4py's support_usm_ndarray
samir-nasibli ecd731d
ENH: functional support for Array API
samir-nasibli f18070f
minor update for support_usm_ndarray decorator
samir-nasibli df682e6
update sklearnex/dispatcher.py
samir-nasibli 23c84f4
fixed dispatcher
samir-nasibli 0483c5c
fixed decorator name
samir-nasibli 459e638
minor update for onedal/_device_offload.py
samir-nasibli 75f9c4b
minor updates
samir-nasibli 27b7a7c
update docstrings for onedal._config._get_config
samir-nasibli dec939e
reverted changes for LogReg refactoring
samir-nasibli 38cc61e
using _get_config instead of _get_onedal_threadlocal_config
samir-nasibli cea22ac
minor fix of _get_config
samir-nasibli 1bb3697
removed TODO, that covered by ticket
samir-nasibli 9ec11b9
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 4179f22
added todo comments
samir-nasibli 694d94b
moved out from _DataParallelInteropPolicy init import of DummySyclQueue
samir-nasibli 8bf2585
removed outdated comment; will be covered on #1813
samir-nasibli e903fbb
removed TODO comment from ridge.py
samir-nasibli 1491b38
Added ElasticNet, Lasso, Ridge into sklearnex patching map
samir-nasibli 81de19e
Merge branch 'main' into enh/functional_array_api
samir-nasibli 3dd5000
lint
samir-nasibli adc6e68
removed debug print
samir-nasibli 652d014
enabled more array api test
samir-nasibli d9f2ef8
Merge branch 'main' into enh/functional_array_api
samir-nasibli 85c279c
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 14c675d
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 669d68f
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli c6e158c
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli ad42750
created seperate array api module
samir-nasibli 7bef6c4
currently disabled array_api for test_memory_leaks
samir-nasibli 88e2a22
update _convert_to_dataframe
samir-nasibli 383ce0d
Merge branch 'main' into enh/functional_array_api
samir-nasibli d8d0dc4
linting
samir-nasibli 45b920f
update condition for _transfer_to_host
samir-nasibli 84da80a
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli eda98a4
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli f74ff13
fixed for bs and ridge
samir-nasibli 7e83e4a
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 4b86143
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli b8348ee
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 0300f72
update fallback when array_api_dispatch enabled
samir-nasibli 5cae80b
refactor sklearnex get_namespace usage
samir-nasibli ac3aacb
updated array apiconditions for get_dataframes_and_queues
samir-nasibli 80da711
fix import in test_memory_usage.py
samir-nasibli 1de8fc9
first temp commit address py312 fails
samir-nasibli 621dfc2
small tmp workaround for py312
samir-nasibli d2f4383
removed from_dlpack from the non-zero support logic
samir-nasibli 16ddb69
fixing tests for incremenatal estimators
samir-nasibli 9be33c2
using asarray instead of dlpack conversions
samir-nasibli e2fa37a
FIX: fixing spmd tests utilities for dpctl inputs
samir-nasibli 016f550
Deselect LOF stability test with array api
samir-nasibli 3e833d7
Revert "Deselect LOF stability test with array api"
samir-nasibli d0fc95d
MAINT: minor refactoring and docstrings added
samir-nasibli 2ff418f
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli df1efc6
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 2094fad
refactoring
samir-nasibli 3004faa
Merge branch 'main' into enh/functional_array_api
samir-nasibli 0fcaafe
minor update for _extract_array_attr
samir-nasibli 5521720
minor update
samir-nasibli 7bd3df0
update conditions for support_array_api
samir-nasibli 19df8f1
update dispatch for array api
samir-nasibli 442826e
covered by tickets TODOs
samir-nasibli fc34a6c
Merge branch 'main' into enh/functional_array_api
samir-nasibli ec634c1
refactor _asarray
samir-nasibli 844745f
update a bit logic
samir-nasibli 752df22
addressed test failes
samir-nasibli fe38790
update docstring
samir-nasibli 3dd9521
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 6989049
Update _array_api.py
samir-nasibli 047d698
minor update
samir-nasibli c5f8281
minor updatte try
samir-nasibli 1b45a24
renamed wrapper for inputs support
samir-nasibli ac7288f
minor refactoring
samir-nasibli d5f3a35
Merge branch 'main' into enh/functional_array_api
samir-nasibli 3915066
fix refactoring
samir-nasibli 95fa66f
addressed test fails
samir-nasibli 8a9e497
remove unnecessary comments
samir-nasibli c66836f
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 3ac9c82
enabled transform_output check
samir-nasibli 819aa8f
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli aa2bf82
update use of transform_output flag for input handlers
samir-nasibli 3539ee3
reverted changes for test_incremental_pca.py
samir-nasibli ad71cd0
Revert "update use of transform_output flag for input handlers"
samir-nasibli 4634c73
Merge branch 'main' into enh/functional_array_api
samir-nasibli 41d1efc
minor refactoring
samir-nasibli 52e9257
fixing
samir-nasibli dd78da4
Merge branch 'intel:main' into enh/functional_array_api
samir-nasibli 4a44e12
minor refactoring
samir-nasibli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple way of one-lining it and removes the branching. You could also replace print with lambda : None if you wanted. Ideally this should only be run if
usm_iface
is None.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This print actually cause some test fails, I can not apply suggestion. Generally the namespace getter will be updated and used here. This will be done as a follow up out of the scope current PR. Ticket is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you send me the fails, I am curious. The suggestion should only yield a self-contained return of a None in the case __array_namespace doesn't exit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/intel/scikit-learn-intelex/actions/runs/10721335064/job/29729604965
Print there caused some test fails. The example of the job is shared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try
array_api = getattr(item, "__array_namespace", lambda : None)()
insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some issue with this as well. Let me check it once again