Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chapter 8 tutorials #399

Merged
merged 35 commits into from
Sep 6, 2023
Merged

Add chapter 8 tutorials #399

merged 35 commits into from
Sep 6, 2023

Conversation

quekyj
Copy link
Contributor

@quekyj quekyj commented Aug 8, 2023

Description & Motivation

Added chapter 8 materials on ROHD abstraction:

  • pipeline
  • fsm
  • interface

Related Issue(s)

Nope

Testing

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

mkorbel1
mkorbel1 requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! just some minor things

doc/tutorials/chapter_8/00_abstraction.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/01_interface.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/01_interface.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/01_interface.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/counter_interface.dart Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/02_finite_state_machine.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/02_finite_state_machine.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/02_finite_state_machine.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/oven_fsm.dart Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/03_pipeline.md Outdated Show resolved Hide resolved
@quekyj
Removed the word more verbose
597bab2
@quekyj
Fix inconsistent use of singular and plural
d944cbb
@quekyj
Fix typo
e7147fe
@quekyj
Fix bug on the counter interface
a8f7193
@quekyj
Modified the tutorials to match with latest verson of code
da0233a
@quekyj
Fix typo to refractorable
7d856fd
@quekyj
Use counterInterface port
2c5430a
@quekyj
Use counterinter instead of counter to access the value of the counter
69caa59
@quekyj
Make the LED width 8 instead of borrowing Button width
bc21eca
@quekyj
Use Map instead of enum
7ac260a
@quekyj
Use Map for light as well
4002c9a
@quekyj
Add FSM mermaid diagram
51e8ea6
@quekyj
Added FSM mermaid diagram into tutorials
3d796b4
@quekyj
Hardcode led width to 8
84e0179
@quekyj
Fix indent on all code
2845960
@quekyj
Fix indent
f07d77a
@quekyj
use simple map instead of enum
aca808d
@quekyj
Do not expose _oven fsm for security issue
4ad22cc
@quekyj
Clean up interface example
7cb6327
@quekyj
Fix broken link
c19ef4a
@quekyj
Delete Old FSM diagram
4636c56
@quekyj
Fix broken image
dea0c66
@quekyj
Update file name
123f4a3
@quekyj quekyj requested a review from mkorbel1 August 29, 2023 01:11
mkorbel1
mkorbel1 requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Nice work!

analysis_options.yaml Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/00_abstraction.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/00_abstraction.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/00_abstraction.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/02_finite_state_machine.md Outdated Show resolved Hide resolved
doc/tutorials/chapter_8/interface_connection.dart Outdated Show resolved Hide resolved
@quekyj quekyj requested a review from mkorbel1 September 4, 2023 03:11
mkorbel1
mkorbel1 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mkorbel1 mkorbel1 merged commit 0d8735e into intel:main Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quekyj @mkorbel1