Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] fixed UR FileCheck conditions to match new traces #15439

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[SYCL][E2E] fixed UR FileCheck conditions to match new traces #15439

merged 3 commits into from
Oct 3, 2024

Conversation

lslusarczyk
Copy link
Contributor

@lslusarczyk lslusarczyk commented Sep 19, 2024 •
edited
Loading

Issue with ugly interleaved Level0 adapter and Level0 Unified Runtime traces, that is oneapi-src/unified-runtime#2002 issue, has been fixed in oneapi-src/unified-runtime#2101.

This PR adds necessary changes to e2e tests to make them pass with modified tracing in L0 Adapter.
This PR also reverts #15167 which disabled some traces because of the bug which is now fixed, so traces can be restored.

@lslusarczyk lslusarczyk changed the title cross check for https://github.com/oneapi-src/unified-runtime/pull/2101 fixed UR FileCheck checks to match call begins Sep 20, 2024
@lslusarczyk lslusarczyk force-pushed the ur-2101-pr-crosscheck branch 2 times, most recently from 653c968 to d3d5ed2 Compare September 20, 2024 12:08
@lslusarczyk lslusarczyk changed the title fixed UR FileCheck checks to match call begins [SYCL][E2E] fixed UR FileCheck conditions to match new traces Sep 20, 2024
@lslusarczyk lslusarczyk marked this pull request as ready for review September 23, 2024 11:07
@lslusarczyk lslusarczyk requested review from a team as code owners September 23, 2024 11:07
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[SYCL][E2E] Fix UR FileCheck conditions to match new traces (intel#15439
ee071a0 
)

makes llvm work with this change: oneapi-src/unified-runtime#2101
fixes this bug: oneapi-src/unified-runtime#2002
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
89d69e7 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 26, 2024
@lslusarczyk
[CI] Ensure old temp dirs do not exist (intel#15439)
0ee3e17 
Install dir can exist if old "SYCL Pre Commit on Windows / e2e"
job has not finished cleanly. Removing it to be sure also on job start.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 27, 2024
@lslusarczyk
[SYCL][E2E] Fix UR FileCheck conditions to match new traces (intel#15439
b214d20 
)

makes llvm work with this change: oneapi-src/unified-runtime#2101
fixes this bug: oneapi-src/unified-runtime#2002
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Sep 27, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
a46743e 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Oct 2, 2024
@lslusarczyk
[SYCL][E2E] Fix UR FileCheck conditions to match new traces (intel#15439
1f9978e 
)

makes llvm work with this change: oneapi-src/unified-runtime#2101
fixes this bug: oneapi-src/unified-runtime#2002
lslusarczyk added a commit to lslusarczyk/llvm that referenced this pull request Oct 2, 2024
@lslusarczyk
[SYCL][E2E] Reverted bypass of L0 adapter tracing in grf tests (intel…
0180aa7 
…#15439)

Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)"
because oneapi-src/unified-runtime#2002 is
fixed

This reverts commit 3e00e38.
@lslusarczyk lslusarczyk mentioned this pull request Oct 3, 2024
Merged
@pbalcer
Copy link
Contributor

pbalcer commented Oct 3, 2024

@intel/llvm-gatekeepers please merge

@steffenlarsen steffenlarsen merged commit e3cfbfe into intel:sycl Oct 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@EwanC EwanC EwanC approved these changes

@sarnex sarnex sarnex approved these changes

@pbalcer pbalcer pbalcer approved these changes

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lslusarczyk @pbalcer @EwanC @sarnex @uditagarwal97 @aelovikov-intel @steffenlarsen