Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Driver] Enable SYCL AOT compilation using --offload-arch #15353

Draft
wants to merge 16 commits into
base: sycl
Choose a base branch
from
Draft

[Driver] Enable SYCL AOT compilation using --offload-arch #15353

wants to merge 16 commits into from

Conversation

srividya-sundaram
Copy link
Contributor

No description provided.

mdtoguchi
mdtoguchi reviewed Sep 11, 2024
View reviewed changes
clang/lib/Driver/Driver.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/Driver.cpp Show resolved Hide resolved
clang/lib/Driver/Driver.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/Driver.cpp Outdated Show resolved Hide resolved
clang/lib/Driver/Driver.cpp Outdated Show resolved Hide resolved
@mdtoguchi
Copy link
Contributor

It looks like the failures are from the changes to check for --offload-arch and -fsycl-targets together without --offload-new-driver. The usage triggering is the alias for --cuda-gpu-arch. Maybe forgo the error diagnostic and emit a warning about 'option unused' (i.e. only claim the --offload-arch usage when we know the value is being used)

@mdtoguchi mdtoguchi closed this Sep 24, 2024
@mdtoguchi mdtoguchi reopened this Sep 24, 2024
@mdtoguchi
Copy link
Contributor

Oops - didn't mean to close :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srividya-sundaram @mdtoguchi