Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHA] Uplift Linux IGC Dev RT version to igc-dev-15caa46 #14761

Merged
merged 4 commits into from
Jul 26, 2024
Merged

[GHA] Uplift Linux IGC Dev RT version to igc-dev-15caa46 #14761

merged 4 commits into from
Jul 26, 2024

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Jul 25, 2024

Scheduled igc dev drivers uplift

@bb-sycl bb-sycl requested a review from a team as a code owner July 25, 2024 03:03
@jsji jsji requested review from a team as code owners July 25, 2024 14:17
@jsji jsji requested a review from sergey-semenov July 25, 2024 14:17
sarnex
sarnex approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I hope we have a tracker for IGC to fix the root problem

@jsji
Copy link
Contributor

jsji commented Jul 25, 2024 •
edited
Loading

LGTM but I hope we have a tracker for IGC to fix the root problem

Thanks @sarnex . I had a look at the issue, the problem should be in how they build the dev igc in the CI. If I build the igc myself, the test pass. And they build the release packaged differently.. :(
So I would think this is a somehow limitation of how dev igc was build in the CI.
But sure, I will open an issue to track it. #14774

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

I wonder why it's only one test if it's a build issue, that seems really weird

@jsji jsji mentioned this pull request Jul 25, 2024
Open
@jsji
Copy link
Contributor

jsji commented Jul 25, 2024

I wonder why it's only one test if it's a build issue, that seems really weird

Yes, it is weird to me too. Maybe it is somehow specific the API used in hardware_dispatch.cpp ?

@jsji
Copy link
Contributor

jsji commented Jul 25, 2024

@intel/llvm-gatekeepers Can someone help to merge this. Thanks.

@steffenlarsen steffenlarsen merged commit e69aa94 into sycl Jul 26, 2024
16 checks passed
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
@bb-sycl @jsji @hdelan
[GHA] Uplift Linux IGC Dev RT version to igc-dev-15caa46 (intel#14761)
998ecd6 
Scheduled igc dev drivers uplift

---------

Co-authored-by: Jinsong Ji <[email protected]>
@bader bader deleted the ci/update_gpu_driver-linux-igc-dev-15caa46 branch September 17, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bb-sycl @jsji @sarnex @sergey-semenov @steffenlarsen @actions-user