-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect support for dynamic linking to user options #14575
Conversation
def fsycl_allow_split_with_dependencies : Flag<["-"], "fsycl-allow-split-with-dependencies">, | ||
Group<sycl_Group>, HelpText<"Allow dependencies between device code images">; | ||
def fno_sycl_allow_split_with_dependencies : Flag<["-"], "fno-sycl-allow-split-with-dependencies">, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need approval from the options group for these, @mdtoguchi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new option in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm only minor comments, the supportDynamicLinking
function is a bit strange but i'm assuming this is an incremental change and it will be fleshed out soon, so it's fine with me
11e5bba
to
a903f6b
Compare
a903f6b
to
bc783e2
Compare
Yes, this function can only return true with the -shared option when the SYCL RT is ready. Otherwise, "-shared" tests may start failing. |
bc783e2
to
3e3318d
Compare
f247d50
to
4eae923
Compare
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
…d for CUDA and hip Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
6ce91e5
to
54d50c4
Compare
54d50c4
to
cfaaa42
Compare
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
All builds have successfully completed after merge with I will proceed with merge, but @LU-JOHN, @maarquitos14, please keep an eye on unfinished jobs in case they highlight any unexpected failures. |
Most likely the clang-format checker was down when #14575 ran CI, so a few changes non-clang-format-compliant made it in. Applying fixes to those. --------- Signed-off-by: Marcos Maronas <[email protected]>
Add option "-fsycl-allow-device-dependencies" to enable support for dynamic linking.
Also:
Tested in three E2E test cases.
Minor change:
Change SYCL-EXTERNAL to SYCL_EXTERNAL in testcase comment.