Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Ensuring lowering of llvm.bitreverse is functionally correct #12774

Merged
merged 18 commits into from
Mar 21, 2024
Merged

[SYCL][E2E] Ensuring lowering of llvm.bitreverse is functionally correct #12774

merged 18 commits into from
Mar 21, 2024
+263 −0

Commits on Mar 15, 2024

  1. [NFC] Ensuring lowering of llvm.bitreverse is functionally correct 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2d91c44 View commit details
    Browse the repository at this point in the history

  2. Do not check for string results. Program will return non-zero for a f… 

    …ailure.

Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    76da721 View commit details
    Browse the repository at this point in the history

  3. Use 'using' instead of 'typedef' 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b17df12 View commit details
    Browse the repository at this point in the history

  4. Do not test on HIP/CUDA. This test is testing lowering in llvm-spirv … 

    …which is not used by HIP/CUDA.

Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    13f4c8a View commit details
    Browse the repository at this point in the history

  5. Test 3,8,16-element vectors 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    084981e View commit details
    Browse the repository at this point in the history

  6. Simplify reference calculation. Use builtin to ensure llvm bitreverse… 

    … intrinsic.

Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ba6aff3 View commit details
    Browse the repository at this point in the history

  7. Do checking and reference bitreverse on host. Refactor more code. 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    de86695 View commit details
    Browse the repository at this point in the history

  8. Initialize seed with srand 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    67737e3 View commit details
    Browse the repository at this point in the history

  9. Ensure SPV_KHR_bit_instructions is not enabled 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d11591f View commit details
    Browse the repository at this point in the history

  10. Ensure SPV dump has expected lowerings. Also check executing without … 

    …explicitly disabling SPV_KHR_bit_instructions passes

Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    52002db View commit details
    Browse the repository at this point in the history

  11. Disable testing without disabling SPV_KHR_bit_instructions because ll… 

    …vm.bitreverse is not supported

Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6565498 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Add testing for 2-element vectors 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7aa9aba View commit details
    Browse the repository at this point in the history

  2. Skip problematic test variation 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    121876c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. v3i64 testing not done. Thus don't check for this SPV result 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    498a5b5 View commit details
    Browse the repository at this point in the history

  2. Remove more v3i64 checking 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e4ab58d View commit details
    Browse the repository at this point in the history

  3. Add V2 checks. Don't do 64-bit vector tests until support is ready. 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1ed5820 View commit details
    Browse the repository at this point in the history

  4. Remove accidentally added files 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    aae59fb View commit details
    Browse the repository at this point in the history

  5. Improve comments 

    Signed-off-by: Lu, John <[email protected]>
    @LU-JOHN
    LU-JOHN committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9d4433d View commit details
    Browse the repository at this point in the history