[CI] Run ESIMD tests on Arc in precommit when ESIMD changed #12651
Conversation
|
@aelovikov-intel Looks like ESIMD + Matrix tests on DG2 take ~14 min. Is that too long? Let's ignore the failures for now, I don't know what's going on but if we want to proceed with this change I'll investigate. |
|
We've had about 75 pre-commit jobs in the last 24 hours. Just pre-commit would take about 18 hours at that pace, and we also use that single runner for post-commit/nightly. I'd say yes, too long. |
|
@aelovikov-intel If we only ran it when there were ESIMD changes is that still too long? I'm not sure how many PRs we have per day but probably 1-3. Maybe I'll actually have to use REST. |
In that case, it would be the right thing to do, even if that is too long. :) I'm also wondering how much the two timed-out tests affected total time. Maybe if we can fix that, the overall time would drop as well. |
|
Good idea, let me try disabling those just for testing and see if it's still long. If so, I'll try to implement the code owner idea. |
|
6m 46s with timed out tests disabled, looks like I'm learning REST ;( |
sarnex
force-pushed
the
ci
branch
2 times, most recently
from
89a3c3a
to
83ae828
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
sarnex
changed the title
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Sarnie, Nick <[email protected]>
| @@ -5,3 +5,6 @@ config.required_features += ['gpu'] | |||
|
|
|||
| if 'gpu-intel-gen9' in config.available_features and platform.system() == 'Windows': | |||
| config.unsupported = True | |||
|
|
|||
| if 'gpu-intel-dg2' in config.available_features: | |||
| config.required_features += ['level_zero'] | |||
There was a problem hiding this comment.
We need this to fix failures when run on OCL. The current DG2 postcommit job only runs L0 anyway, so there's no difference in coverage. We should investigate why OCL fails separately.
There was a problem hiding this comment.
That comment should go into the source file :)
There was a problem hiding this comment.
done thanks and thanks for all your help with this, this stuff is really painful
Signed-off-by: Sarnie, Nick <[email protected]>
|
@intel/dpcpp-esimd-reviewers Please review this one ASAP, we can have DG2 testing in precommit after this is merged |
| - name: Set Arc tests | ||
| id: arc_tests | ||
| run: | | ||
| if [ "${{ contains(steps.result.outputs.result, 'esimd') }}" == "true" ]; then | ||
| echo 'arc_tests="(ESIMD|InvokeSimd|Matrix)/"' >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo 'arc_tests="Matrix/"' >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
Hm, I've just realised that it's not in the precommit yml file. What was the reason? We haven't had any real logic here before this change.
There was a problem hiding this comment.
I felt it's related more to processing the changes list which we already do in that yml, and the complexity of the logic seems to be similar to the existing 'Set output' job in the same file. I can move it if you'd prefer but I'd ask to like to do it in a separate PR because my team needs this testing ASAP.
There was a problem hiding this comment.
Yes, I'd like it moved. The reason is that I want this file to detect undisputable facts only and the tests we want to run on a given runner is "subjective" in nature. I'm ok with doing it in the next PR.
There was a problem hiding this comment.
Thanks I will do it immediate after this is merged
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Failures not related, see |
Let's see if this works