Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] XPASS->UNSUPPORTED for KernelFusion/Reduction/reduction.cpp #12607

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

aelovikov-intel
Copy link
Contributor

@sommerlukas
Copy link
Contributor

sommerlukas commented Feb 5, 2024

@aelovikov-intel We have identified the underlying issue and found a fix for the combination of fusion and reduction in #12593, which would supersede the change in this PR.
#12593 is currently blocked by outstanding reviews on #12556.

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Feb 5, 2024

@aelovikov-intel We have identified the underlying issue and found a fix for the combination of fusion and reduction in #12607, which would supersede the change in this PR. #12607 is currently blocked by outstanding reviews on #12556.

I think you had copy-paste errors with PR numbers, as you've mentioned this PR multiple times. That said, when do you expect the fix to be merged in? Unless that happens today, I'd like this to be merged so that next Nightly run won't have the failure.

@sommerlukas
Copy link
Contributor

I think you had copy-paste errors with PR numbers

Yes, sorry, fixed that.

@sommerlukas
Copy link
Contributor

That said, when do you expect the fix to be merged in?

As it's blocked by outstanding reviews on #12556, I don't expect that to be merged today.

Is the XFAIL from #12540 not sufficient for Nightly?

@aelovikov-intel
Copy link
Contributor Author

Is the XFAIL from #12540 not sufficient for Nightly?

Not anymore, because it does NOT fail when running on Intel CPU (on our Intel Arc GPU runner).

@aelovikov-intel aelovikov-intel merged commit 20aee78 into intel:sycl Feb 5, 2024
12 checks passed
@aelovikov-intel aelovikov-intel deleted the fusion-red-test branch February 5, 2024 19:16
@aelovikov-intel
Copy link
Contributor Author

Post commit failures on Intel Arc GPU:

Failed Tests (1):
  SYCL :: Basic/device.cpp
FAIL: SYCL :: Basic/device.cpp (160 of 1873)
******************** TEST 'SYCL :: Basic/device.cpp' FAILED ********************
Exit Code: -6

Command Output (stdout):
--
# RUN: at line 1
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/device.cpp -o /__w/llvm/llvm/build-e2e/Basic/Output/device.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/device.cpp -o /__w/llvm/llvm/build-e2e/Basic/Output/device.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 2
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/Basic/Output/device.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/Basic/Output/device.cpp.tmp.out
# .---command stdout------------
# | Default device type: OpenCL.GPU
# | Get all devices in the system
# | Device 1 is available: OpenCL.GPU
# | Device 2 is available: OpenCL.GPU
# | Get host devices in the system
# | Get OpenCL.CPU devices in the system
# | Get OpenCL.GPU devices in the system
# | Device 1 is available: OpenCL.GPU
# | Device 2 is available: OpenCL.GPU
# | Get OpenCL.ACC devices in the system
# | move constructor
# | move assignment operator
# | copy constructor
# | copy assignment operator
# | Abort was called at 253 line in file:
# | ../../neo/level_zero/core/source/builtin/builtin_functions_lib_impl.cpp
# `-----------------------------
# .---command stderr------------
# | pure virtual method called
# | terminate called without an active exception
# `-----------------------------
# error: command failed with exit status: -6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants