[SYCL][ESIMD]Implement gather(lacc) accepting compile time properties #12533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
# Conflicts: # sycl/test/esimd/memory_properties.cpp
v-klochkov
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Looks really good! I cannot add anything except fixing 1 letter ))
@sarnex - please also take a look, I could miss something.
Assume approved, but pending to review/approval from Nick. Thank you.
sarnex
approved these changes
Feb 1, 2024
| /// simd<T, N> gather(AccessorT acc, simd<uint32_t, N / VS> byte_offsets, | ||
| /// simd_mask<N / VS> mask, | ||
| /// PropertyListT props = {}); // (lacc-ga-2) | ||
| /// Supported platforms: DG2, PVC in most cases. The DG2/PVC is not required if |
There was a problem hiding this comment.
Suggested change
| /// Supported platforms: DG2, PVC in most cases. The DG2/PVC is not required if | |
| /// Supported platforms: DG2, PVC in most cases. DG2/PVC is not required if |
Nit, same thing in a few places
| /// simd_mask<N> mask, simd<T, N> pass_thru, | ||
| /// PropertyListT props = {}); // (lacc-ga-4) | ||
| /// This function is identical to (lacc-ga-1) except that vector size is fixed | ||
| /// to 1. This variant is added for convenience and let user omit the template |
There was a problem hiding this comment.
Suggested change
| /// to 1. This variant is added for convenience and let user omit the template | |
| /// to 1. This variant is added for convenience and lets the user omit the template |
same thing in a few places, just a nit
| /// | ||
| /// The next 3 functions are similar to (lacc-ga-1,2,3), but they don't have | ||
| /// the template parameter 'VS'. These functions are added for convenience and | ||
| /// to make it possible for user to omit the template parameters T and N, |
There was a problem hiding this comment.
Suggested change
| /// to make it possible for user to omit the template parameters T and N, | |
| /// to make it possible for the user to omit the template parameters T and N, |
sarnex
approved these changes
Feb 2, 2024
v-klochkov
reviewed
Feb 2, 2024
v-klochkov
approved these changes
Feb 2, 2024
Co-authored-by: Vyacheslav Klochkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the unified memory API for gather with local accessors