Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Add urProgramGetGlobalVariablePointer entrypoint #12496

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

fabiomestre
Copy link
Contributor

No description provided.

@fabiomestre fabiomestre changed the title [TEST ONLY] Update UR tag [TEST ONLY] Update UR tag to test change Jan 25, 2024
@fabiomestre fabiomestre force-pushed the fabio/add_global_variable_pointer branch from 512ba15 to 2dd9099 Compare January 25, 2024 17:17
@fabiomestre fabiomestre force-pushed the fabio/add_global_variable_pointer branch 2 times, most recently from ef3025e to e1d0b8c Compare February 23, 2024 13:59
@fabiomestre fabiomestre force-pushed the fabio/add_global_variable_pointer branch from e1d0b8c to fa51e98 Compare February 23, 2024 14:01
@fabiomestre fabiomestre force-pushed the fabio/add_global_variable_pointer branch from fa51e98 to 5f197a8 Compare February 26, 2024 15:29
@fabiomestre fabiomestre force-pushed the fabio/add_global_variable_pointer branch from 5f197a8 to 208d396 Compare February 26, 2024 15:47
@fabiomestre fabiomestre changed the title [TEST ONLY] Update UR tag to test change [UR] Add urProgramGetGlobalVariablePointer entrypoint Feb 26, 2024
@fabiomestre fabiomestre marked this pull request as ready for review February 27, 2024 10:58
@fabiomestre fabiomestre requested review from a team as code owners February 27, 2024 10:58
@@ -56,14 +56,14 @@ endif()
if(SYCL_PI_UR_USE_FETCH_CONTENT)
include(FetchContent)

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
set(UNIFIED_RUNTIME_REPO "https://github.com/fabiomestre/unified-runtime.git")
Copy link
Contributor Author

@fabiomestre fabiomestre Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated to point to the right commit / repo once the PR on the Unified Runtime repo is merged: oneapi-src/unified-runtime#1255

@fabiomestre
Copy link
Contributor Author

Gentle ping for reviews from @intel/dpcpp-nativecpu-pi-reviewers @intel/llvm-reviewers-cuda @sergey-semenov

Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP LGTM

@kbenzie kbenzie self-assigned this Mar 14, 2024
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a version bump, then this looks good!

sycl/include/sycl/detail/pi.h Show resolved Hide resolved
@kbenzie
Copy link
Contributor

kbenzie commented Mar 19, 2024

@intel/llvm-gatekeepers please merge

@sarnex sarnex merged commit 046d998 into intel:sycl Mar 19, 2024
12 checks passed
kbenzie added a commit to kbenzie/llvm that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants