Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD]Fix lsc_slm_block_load test #12484

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Jan 24, 2024

No description provided.

@fineg74 fineg74 requested a review from a team as a code owner January 24, 2024 18:05
@fineg74
Copy link
Contributor Author

fineg74 commented Jan 24, 2024

ESIMD/matrix_transpose_glb.cpp test failures are not related to the change

Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this change can fix something.
It is even look wrong to me.
The initialization is done in int-type equivalent units - similarly as the verification is done later. That is done intentionally to avoid bits lost or roundings for FP types.
For example, Vals gets different numbers than 1M*GroupID when it is T and when it is Tuint.

@sarnex
Copy link
Contributor

sarnex commented Jan 24, 2024

ExpectedVal in the verification for the transpose case is using T but the kernel uses Tuint, I assumed that's the problem.

@v-klochkov
Copy link
Contributor

ExpectedVal in the verification for the transpose case is using T but the kernel uses Tuint, I assumed that's the problem.

Ough..., I see now. It seem it is some mess in init/use/verify code here. non-transpose verification has Uint to verify with expected values, but both transposed/non-transposed use the common LSM initialization code.

@v-klochkov
Copy link
Contributor

AWS-CUDA fails are unrelated to changes in 2 ESIMD E2E tests. Proceeding to merge now.

@v-klochkov v-klochkov merged commit e4113f1 into intel:sycl Feb 5, 2024
11 of 12 checks passed
@fineg74 fineg74 deleted the lsc_slm_load branch February 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants