[UR][Spec Constants] Improved handling of invalid/unsupported spec. c…

…onstants

Pre-commit MR for oneapi-src/unified-runtime#1469

sycl/plugins/unified_runtime/CMakeLists.txt

@@ -99,24 +99,29 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
       CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
   endfunction()
 
-  set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
-  # commit 755a1e75e24ed55070a0f457d2d8a676521ad4f7
-  # Merge: 6469b890 5593d84c
-  # Author: Kenneth Benzie (Benie) <[email protected]>
-  # Date:   Tue Jun 4 10:34:57 2024 +0100
-  #     Merge pull request #1385 from yingcong-wu/yc/new-api-suggestgroupsize
-  #     Implement urKernelGetSuggestedLocalWorkSize
-  set(UNIFIED_RUNTIME_TAG 755a1e75e24ed55070a0f457d2d8a676521ad4f7)
+  set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git")
+  # commit 66dfff82b9c95e3ca1847e2d6f3aca38bcb44298
+  # Author: Ross Brunton <[email protected]>
+  # Date:   Fri Mar 22 17:18:22 2024 +0000
+  #
+  #     [Spec Constants] Improved handling of invalid/unsupported spec. constants
+  #
+  #     Two main changes to how `Kernel/ProgramSetSpecializationConstants`
+  #     are handled:
+  #     * They may now output either `INVALID_VALUE` or the new
+  #       `INVALID_SPEC_ID` when the provided list is invalid.
+  #     * The OpenCL and level 0 adapters now respond to
+  #       `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false`
+  #       rather than erroring out. This fixes some tests that were
+  #       incorrectly not being skipped.
+  #     * `urKernelSetSpecializationConstants` now "implemented" (as a
+  #       function that returns `UNSUPPORTED_FEATURE` for a number of
+  #       adapters.
+  set(UNIFIED_RUNTIME_TAG 66dfff82b9c95e3ca1847e2d6f3aca38bcb44298)
 
   fetch_adapter_source(level_zero
     ${UNIFIED_RUNTIME_REPO}
-    # commit 8e47ab5057458c5522ce5d86f7996b2882020220
-    # Merge: b816fe82 3d3aba65
-    # Author: Kenneth Benzie (Benie) <[email protected]>
-    # Date:   Tue Jun 4 17:28:43 2024 +0100
-    #     Merge pull request #1694 from Bensuo/ewan/L0_update_query
-    #     Set minimum L0 device support to support UR kernel update
-    8e47ab5057458c5522ce5d86f7996b2882020220
+    ${UNIFIED_RUNTIME_TAG}
   )
 
   fetch_adapter_source(opencl
@@ -126,35 +131,17 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
 
   fetch_adapter_source(cuda
     ${UNIFIED_RUNTIME_REPO}
-    # commit 0e38fda02ca00aaab28018240eb526da7dd08f56
-    # Merge: f4968809 b7c8ac18
-    # Author: Kenneth Benzie (Benie) <[email protected]>
-    # Date:   Tue Jun 4 14:18:15 2024 +0100
-    #     Merge pull request #1552 from mmoadeli/atomic-access-on-host-malloc
-    #     [CUDA] Remove the support of concurrent atomic access to host allocated pinned memory.
-    0e38fda02ca00aaab28018240eb526da7dd08f56
+    ${UNIFIED_RUNTIME_TAG}
   )
 
   fetch_adapter_source(hip
     ${UNIFIED_RUNTIME_REPO}
-    # commit 399430da9613269a0dc8ddf605415942e0a37e9c
-    # Merge: 39cb69ab 10b04891
-    # Author: Kenneth Benzie (Benie) <[email protected]>
-    # Date:   Tue Jun 4 17:15:33 2024 +0100
-    #     Merge pull request #1688 from frasercrmck/hip-enqueue-mem-readwritecopy
-    #     [HIP] Various fixes for urEnqueueMemImage(Read|Write|Copy)
-    399430da9613269a0dc8ddf605415942e0a37e9c
+    ${UNIFIED_RUNTIME_TAG}
   )
 
   fetch_adapter_source(native_cpu
     ${UNIFIED_RUNTIME_REPO}
-    # commit 31ee5d536130a6d2ce09661db1bef3bd1cd4d705
-    # Merge: ab151e98 53e43466
-    # Author: Kenneth Benzie (Benie) <[email protected]>
-    # Date:   Tue Jun 4 14:10:39 2024 +0100
-    #     Merge pull request #1527 from PietroGhg/pietro/report_atomics
-    #     [NATIVECPU] Report correct memory order capabilities for Native CPU
-    31ee5d536130a6d2ce09661db1bef3bd1cd4d705
+    ${UNIFIED_RUNTIME_TAG}
   )
 
   if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)