Skip to content

Commit

Permalink
[SYCL][E2E][Bindless] Use REQUIRES: aspect-ext_oneapi_bindless_images (
Browse files Browse the repository at this point in the history
…#15211)

Basic SYCL bindless image e2e tests can now pass on DG2/BMG/MTL/LNL.
Adjust REQUIRES check for supported GPUs other than DG2.

UR PR: oneapi-src/unified-runtime#2018

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
  • Loading branch information
wenju-he and kbenzie authored Oct 7, 2024
1 parent 9995592 commit a4f74a9
Show file tree
Hide file tree
Showing 21 changed files with 27 additions and 27 deletions.
14 changes: 7 additions & 7 deletions sycl/cmake/modules/FetchUnifiedRuntime.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ if(SYCL_UR_USE_FETCH_CONTENT)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 7907998a442b381a6669d2ae5ab957f8ddda5d03
# Merge: 7e9d9d47 ae7f58e3
# Author: aarongreig <aaron.greig@codeplay.com>
# Date: Fri Oct 4 11:35:10 2024 +0100
# Merge pull request #2121 from nrspruit/error_after_free_syclos
# [L0] Refcnt Parent Buffer on Sub Buffer Create and die on use of buffer after free
set(UNIFIED_RUNTIME_TAG 7907998a442b381a6669d2ae5ab957f8ddda5d03)
# commit b79ebe4e98789144bcdf3832088eb6e6b5ae6967
# Merge: 7b4bc761 fbb6e862
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
# Date: Fri Oct 4 16:39:59 2024 +0100
# Merge pull request #2018 from wenju-he/L0-bindless-image-device-query
# [L0] Fix device query of bindless image support
set(UNIFIED_RUNTIME_TAG b79ebe4e98789144bcdf3832088eb6e6b5ae6967)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: linux
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: %{run} env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images
// REQUIRES: windows

// RUN: %{build} -l d3d12 -l dxgi -l dxguid -o %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_1D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_2D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_2D_dynamic.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_3D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_norm_types.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_1D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_1D_subregion.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_2D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_2D_subregion.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_3D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_3D_subregion.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/read_write_unsampled.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/sampling_1D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/sampling_2D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/sampling_2D_half.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images
// REQUIRES: aspect-fp16

// RUN: %{build} -o %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/sampling_3D.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (level_zero && gpu-intel-dg2)
// REQUIRES: aspect-ext_oneapi_bindless_images

// RUN: %{build} -o %t.out
// RUN: env NEOReadDebugKeys=1 UseBindlessMode=1 UseExternalAllocatorForSshAndDsh=1 %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (windows && level_zero && gpu-intel-dg2)
// REQUIRES: cuda || (windows && level_zero && aspect-ext_oneapi_bindless_images)
// REQUIRES: vulkan

// RUN: %{build} %link-vulkan -o %t.out %if any-device-is-level_zero %{ -Wno-ignored-attributes -DENABLE_LINEAR_TILING -DTEST_L0_SUPPORTED_VK_FORMAT %}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: cuda || (windows && level_zero && gpu-intel-dg2)
// REQUIRES: cuda || (windows && level_zero && aspect-ext_oneapi_bindless_images)
// REQUIRES: vulkan

// RUN: %{build} %link-vulkan -o %t.out %if any-device-is-level_zero %{ -Wno-ignored-attributes -DTEST_L0_SUPPORTED_VK_FORMAT %}
Expand Down

0 comments on commit a4f74a9

Please sign in to comment.