Skip to content

Commit

Permalink
[UR][Spec Constants] Improved handling of invalid/unsupported spec. c…
Browse files Browse the repository at this point in the history
…onstants

Pre-commit MR for oneapi-src/unified-runtime#1469
  • Loading branch information
RossBrunton committed Aug 14, 2024
1 parent 07bf3c1 commit 703b28e
Showing 1 changed file with 19 additions and 8 deletions.
27 changes: 19 additions & 8 deletions sycl/cmake/modules/FetchUnifiedRuntime.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,25 @@ if(SYCL_UR_USE_FETCH_CONTENT)
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit f8336050f43a6529636fd6b2075dfe09961564f5
# Merge: 6c98e0e8 b75f2bc2
# Author: Omar Ahmed <[email protected]>
# Date: Tue Aug 13 13:07:23 2024 +0100
# Merge pull request #1955 from nrspruit/fix_l0_coverity
# [L0] fix Coverity issues for L0 Adapter
set(UNIFIED_RUNTIME_TAG f8336050f43a6529636fd6b2075dfe09961564f5)
set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git")
# commit put-git-commit-hash-here
# Author: Ross Brunton <[email protected]>
# Date: Fri Mar 22 17:18:22 2024 +0000
#
# [Spec Constants] Improved handling of invalid/unsupported spec. constants
#
# Two main changes to how `Kernel/ProgramSetSpecializationConstants`
# are handled:
# * They may now output either `INVALID_VALUE` or the new
# `INVALID_SPEC_ID` when the provided list is invalid.
# * The OpenCL and level 0 adapters now respond to
# `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false`
# rather than erroring out. This fixes some tests that were
# incorrectly not being skipped.
# * `urKernelSetSpecializationConstants` now "implemented" (as a
# function that returns `UNSUPPORTED_FEATURE` for a number of
# adapters.
set(UNIFIED_RUNTIME_TAG fe17c7f95bce149600bf76a8b636ee5bef275093)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down

0 comments on commit 703b28e

Please sign in to comment.