Skip to content

Commit

Permalink
[UR][Spec Constants] Improved handling of invalid/unsupported spec. c…
Browse files Browse the repository at this point in the history
…onstants

Pre-commit MR for oneapi-src/unified-runtime#1469
  • Loading branch information
RossBrunton committed May 23, 2024
1 parent ab6cc47 commit 456150d
Showing 1 changed file with 20 additions and 15 deletions.
35 changes: 20 additions & 15 deletions sycl/plugins/unified_runtime/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,25 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 85771876a5c2a13e3b24c048f0c0d81720d47ccc
# Merge: 42d72b66 00edaab9
# Author: Kenneth Benzie (Benie) <[email protected]>
# Date: Tue May 21 10:15:03 2024 +0100
# Merge pull request #1401 from ph0b/patch-1
# [UR][L0] Return device version based on DeviceIpVersion
set(UNIFIED_RUNTIME_TAG 85771876a5c2a13e3b24c048f0c0d81720d47ccc)
set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git")
# commit 2ceefbaaf02acab7a7f14b29e1e94ceb6891ed66
# Author: Ross Brunton <[email protected]>
# Date: Fri Mar 22 17:18:22 2024 +0000
#
# [Spec Constants] Improved handling of invalid/unsupported spec. constants
#
# Two main changes to how `Kernel/ProgramSetSpecializationConstants`
# are handled:
# * They may now output either `INVALID_VALUE` or the new
# `INVALID_SPEC_ID` when the provided list is invalid.
# * The OpenCL and level 0 adapters now respond to
# `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false`
# rather than erroring out. This fixes some tests that were
# incorrectly not being skipped.
# * `urKernelSetSpecializationConstants` now "implemented" (as a
# function that returns `UNSUPPORTED_FEATURE` for a number of
# adapters.
set(UNIFIED_RUNTIME_TAG 263f13e4622f31d5f12c821b737eda4a74682170)

fetch_adapter_source(level_zero
${UNIFIED_RUNTIME_REPO}
Expand All @@ -115,13 +126,7 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)

fetch_adapter_source(cuda
${UNIFIED_RUNTIME_REPO}
# commit d3502dc1c1eac924736fc08529e4d5f149648fd1
# Merge: c911a9b6 71420060
# Author: Kenneth Benzie (Benie) <[email protected]>
# Date: Wed May 22 10:38:34 2024 +0100
# Merge pull request #1565 from hdelan/cuda-multi-dev-ctx
# [CUDA] CUDA adapter multi device context
d3502dc1c1eac924736fc08529e4d5f149648fd1
${UNIFIED_RUNTIME_TAG}
)

fetch_adapter_source(hip
Expand Down

0 comments on commit 456150d

Please sign in to comment.