Skip to content

Commit

Permalink
[UR][Spec Constants] Improved handling of invalid/unsupported spec. c…
Browse files Browse the repository at this point in the history
…onstants

Pre-commit MR for oneapi-src/unified-runtime#1469
  • Loading branch information
RossBrunton committed Oct 2, 2024
1 parent ce0dc32 commit 402eb28
Showing 1 changed file with 18 additions and 8 deletions.
26 changes: 18 additions & 8 deletions sycl/cmake/modules/FetchUnifiedRuntime.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,24 @@ if(SYCL_UR_USE_FETCH_CONTENT)
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit 0247d0966ca8c5d1e3245f375e48e6c997bed9af
# Merge: 675dd292 04ffc909
# Author: aarongreig <[email protected]>
# Date: Tue Oct 1 17:10:58 2024 +0100
# Merge pull request #2154 from npmiller/fix-graph-exce
# [CUDA][HIP] Fix exceptions throwing from adapter
set(UNIFIED_RUNTIME_TAG 0247d0966ca8c5d1e3245f375e48e6c997bed9af)
set(UNIFIED_RUNTIME_REPO "https://github.com/RossBrunton/unified-runtime.git")
# commit 713770dbce3afab8d182ae96721c0232248ce4e5
# Author: Ross Brunton <[email protected]>
# Date: Fri Mar 22 17:18:22 2024 +0000
# [Spec Constants] Improved handling of invalid/unsupported spec. constants
#
# Two main changes to how `Kernel/ProgramSetSpecializationConstants`
# are handled:
# * They may now output either `INVALID_VALUE` or the new
# `INVALID_SPEC_ID` when the provided list is invalid.
# * The OpenCL and level 0 adapters now respond to
# `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false`
# rather than erroring out. This fixes some tests that were
# incorrectly not being skipped.
# * `urKernelSetSpecializationConstants` now "implemented" (as a
# function that returns `UNSUPPORTED_FEATURE` for a number of
# adapters.
set(UNIFIED_RUNTIME_TAG 713770dbce3afab8d182ae96721c0232248ce4e5)

set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down

0 comments on commit 402eb28

Please sign in to comment.