-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase warmup
and rep
for FA benchmark
#2256
Open
anmyachev
wants to merge
17
commits into
main
Choose a base branch
from
amyachev/bench-time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b1d2a0b
Increase 'warmup' and 'rep' for FA benchmark
anmyachev 339b709
Merge branch 'main' into amyachev/bench-time
anmyachev 5ebbd01
Use 150ms
anmyachev b1cc599
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev 0ad146f
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev bbf0557
Merge branch 'main' into amyachev/bench-time
anmyachev 81fec9a
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev 42e653a
Merge branch 'main' into amyachev/bench-time
anmyachev 8f81c13
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev 5d08d3a
Merge branch 'main' into amyachev/bench-time
anmyachev b2d3398
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev fe806b1
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev bf49b0d
fix after merge
anmyachev 7493632
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev 524f81d
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev 4d40864
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev b0d91ce
Update benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchm…
anmyachev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From 10 to 600 times? Way too many repetitions. It is going to slow down the time it takes to run the benchmarks too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is measured in milliseconds and is needed for some test combinations where one run takes more than 100 ms.