NUMA bindings support for private memory #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Do you think you could add in the forcePageAllocation method from PosixShmSegment.cpp, so that each page is prefaulted? See https://github.com/intel/CacheLib/blob/main/cachelib/shm/PosixShmSegment.cpp#L350. This reduces the number of minor page faults dramatically (from over 1.7M down to ~100K). |
I think PR #81 should help in that case. |
igchor
approved these changes
May 4, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, all discussions resolved (waiting on @byrnedj)
vinser52
added a commit
that referenced
this pull request
Jul 17, 2023
byrnedj
pushed a commit
that referenced
this pull request
Jul 23, 2023
vinser52
added a commit
that referenced
this pull request
Feb 29, 2024
vinser52
added a commit
that referenced
this pull request
Mar 1, 2024
byrnedj
pushed a commit
that referenced
this pull request
May 21, 2024
byrnedj
pushed a commit
that referenced
this pull request
Jun 25, 2024
byrnedj
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can merge these changes to our develop branch while we are waiting for PR95 to be upstreamed.
This change is