Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1965 in literature #866

Closed
wants to merge 4 commits into from
Closed

1965 in literature #866

wants to merge 4 commits into from

Conversation

reformanda
Copy link

related to: #833

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • ...
  • ...
  • ...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • Content does not include PII or otherwise sensitive or confidential information
  • Content does not include anything documented in the project's Avoid these Topics guidelines

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels May 7, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

jjasghar
jjasghar requested changes May 14, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting issues and created_by.

knowledge/literature/novels/shogun/qna.yaml Outdated Show resolved Hide resolved
@jjasghar
Copy link
Member

And DCO too please :)

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels May 14, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 15, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar jjasghar changed the title added some qna for 1965 1965 in literature May 16, 2024
@jjasghar
Copy link
Member

Please fix the DCO and the linting issues.

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 16, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 18, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@github-actions github-actions bot added documentation Improvements or additions to documentation ci labels May 18, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

jjasghar
jjasghar requested changes May 18, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash down to on commit also. 31 is a little excessive.

.github/workflows/coc_violation_analysis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR.

knowledge/literature/published_1965/qna.yaml Outdated
question: What book did American author Robin Moore write in 1965?
- answer: The International Poetry Incarnation was an event at the Royal Albert Hall in London on 11 June 1965.
question: Were there any poetry events in 1965?
task_description: 'training'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this task description is correct.

@jjasghar jjasghar removed documentation Improvements or additions to documentation triage-needed (Auto labeled) skill is ready to be triaged ci labels May 18, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 18, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar
Copy link
Member

Please remove the non relevant files before we can move farther with this.

@reformanda
squash some commits
0509415 
Signed-off-by: JDWilson <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation ci labels May 18, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar jjasghar removed documentation Improvements or additions to documentation ci labels May 18, 2024
@jjasghar
Copy link
Member

Please fix the DCO issue.

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 19, 2024
@jjasghar
Copy link
Member

jjasghar commented May 20, 2024 •
edited
Loading

The wikipedia page we used for this bounty is too many lists for the model to handle. Just not a great knowledge submission, Julia’s fault for not noticing beforehand!

Sorry it turns out we need to close this one. Thank you for doing all this work, but this won't be accepted nor any 1965 Lit PRs from Red Hat Summit 2024.

@jjasghar jjasghar closed this May 20, 2024
@jjasghar jjasghar added triage-rejected PR fails to meet criteria and removed triage-requested-changes skill has been reviewed; changes requested from contributor labels May 20, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjasghar jjasghar jjasghar requested changes

Assignees
No one assigned
Labels
knowledge (Auto labeled) triage-rejected PR fails to meet criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reformanda @jjasghar