Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBC #1032

Closed
wants to merge 5 commits into from
Closed

BBC #1032

wants to merge 5 commits into from

Conversation

akesterton
Copy link

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

  • ...
  • ...
  • ...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

  • The contribution was tested with ilab generate
  • No errors or warnings were produced by ilab generate
  • All commits are signed off (DCO)
  • The qna.yaml file contains at least 5 seed_examples
  • The qna.yaml file was linted and prettified (yaml-validator can do both)
  • An attribution.txt file in the same folder as the qna.yaml file
  • Content does not include PII or otherwise sensitive or confidential information
  • Content does not include anything documented in the project's Avoid these Topics guidelines

@akesterton
Add files via upload
b39fbc1 
Signed-off-by: Anthony Kesterton <[email protected]>
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels May 9, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@akesterton akesterton changed the title Add files via upload BBC May 9, 2024
jjasghar
jjasghar requested changes May 13, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes then we can re-run the linter.

knowledge/studios/bbc_studios/qna.txt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this name to qna.yaml.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, misread the instructions. Changed as requested.

knowledge/studios/bbc_studios/qna.txt Outdated
@@ -0,0 +1,27 @@
created_by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your GitHub username here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And missed this bit too - changed as requested

@jjasghar jjasghar added triage-requested-changes skill has been reviewed; changes requested from contributor and removed triage-needed (Auto labeled) skill is ready to be triaged labels May 13, 2024
@akesterton
Rename qna.txt to qna.yaml
f4e5243 
Signed-off-by: Anthony Kesterton <[email protected]>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

jjasghar
jjasghar requested changes May 14, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these issues.

knowledge/studios/bbc_studios/qna.yaml Outdated
@@ -0,0 +1,27 @@
created_by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your GitHub Username here

knowledge/studios/bbc_studios/attribution.txt Outdated
Link to work: https://en.wikipedia.org/wiki/BBC_Studios
Revision: https://en.wikipedia.org/w/index.php?title=BBC_Studios&oldid=1221919574
License of the work: CC-BY-SA-4.0
Creator names: akesterton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should we Wikipedia Authors

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
@akesterton
Update qna.yaml
d4bb37f 
Corrected created_by field to my username

Signed-off-by: Anthony Kesterton <[email protected]>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
@instruct-lab-bot instruct-lab-bot
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@akesterton
Update attribution.txt
995ecd5 
Add link to list of page editors.

Signed-off-by: Anthony Kesterton <[email protected]>
@jjasghar
Copy link
Member

Please fix the linting issues.

@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label May 14, 2024
jjasghar
jjasghar requested changes May 14, 2024
View reviewed changes
Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linting issues.

jjasghar added a commit that referenced this pull request Jun 12, 2024
@jjasghar @dhrhtrn
@GrahamSadler @JAGHorta @umikkilineni @CrocusChido @alonsocamaro @akesterton @kaileshmistry
BBC Studios (combined)
b572c81 
This is the combined PR about BBC Studios from Red Hat Summit 2024.

This superseeds: #892 #896 #928 #1000 #1012 #1020 #1032 #1036

Co-authored-by: dhrhtrn <[email protected]>
Co-authored-by: GrahamSadler <[email protected]>
Co-authored-by: JAGHorta <[email protected]>
Co-authored-by: umikkilineni <[email protected]>
Co-authored-by: CrocusChido <[email protected]>
Co-authored-by: alonsocamaro <[email protected]>
Co-authored-by: Anthony Kesterton <[email protected]>
Co-authored-by: Kailesh Mistry <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
@jjasghar jjasghar mentioned this pull request Jun 12, 2024
Closed
@jjasghar
Copy link
Member

Closing because of combined PR here: #1187

@jjasghar jjasghar closed this Jun 12, 2024
jjasghar added a commit that referenced this pull request Jun 12, 2024
@jjasghar @dhrhtrn
@GrahamSadler @JAGHorta @umikkilineni @CrocusChido @alonsocamaro @akesterton @kaileshmistry
BBC Studios (combined)
91b4bbf 
This is the combined PR about BBC Studios from Red Hat Summit 2024.

This superseeds: #892 #896 #928 #1000 #1012 #1020 #1032 #1036

Co-authored-by: dhrhtrn <[email protected]>
Co-authored-by: GrahamSadler <[email protected]>
Co-authored-by: JAGHorta <[email protected]>
Co-authored-by: umikkilineni <[email protected]>
Co-authored-by: CrocusChido <[email protected]>
Co-authored-by: alonsocamaro <[email protected]>
Co-authored-by: Anthony Kesterton <[email protected]>
Co-authored-by: Kailesh Mistry <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
jjasghar added a commit that referenced this pull request Jun 12, 2024
@jjasghar @dhrhtrn
@GrahamSadler @JAGHorta @umikkilineni @CrocusChido @alonsocamaro @akesterton @kaileshmistry
BBC Studios (combined)
70c726e 
This is the combined PR about BBC Studios from Red Hat Summit 2024.

This superseeds: #892 #896 #928 #1000 #1012 #1020 #1032 #1036

Co-authored-by: dhrhtrn <[email protected]>
Co-authored-by: GrahamSadler <[email protected]>
Co-authored-by: JAGHorta <[email protected]>
Co-authored-by: umikkilineni <[email protected]>
Co-authored-by: CrocusChido <[email protected]>
Co-authored-by: alonsocamaro <[email protected]>
Co-authored-by: Anthony Kesterton <[email protected]>
Co-authored-by: Kailesh Mistry <[email protected]>
Signed-off-by: JJ Asghar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjasghar jjasghar jjasghar requested changes

Assignees
No one assigned
Labels
knowledge (Auto labeled) triage-requested-changes skill has been reviewed; changes requested from contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akesterton @jjasghar