fix: 🖤 Update the menu bar status icon for Dark Mode (#38)

inseven · Jun 24, 2024 · d54919d · d54919d
1 parent 36402a0
commit d54919d
Show file tree

Hide file tree

Showing 13 changed files with 106 additions and 44 deletions.
diff --git a/Reconnect/Assets.xcassets/Connected.imageset/Contents.json b/Reconnect/Assets.xcassets/Connected.imageset/Contents.json
diff --git a/Reconnect/Assets.xcassets/Disconnected.imageset/Contents.json b/Reconnect/Assets.xcassets/Disconnected.imageset/Contents.json
diff --git a/Reconnect/Assets.xcassets/StatusConnected.imageset/Contents.json b/Reconnect/Assets.xcassets/StatusConnected.imageset/Contents.json
@@ -0,0 +1,52 @@
+{
+  "images" : [
+    {
+      "filename" : "StatusConnected.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "StatusConnectedDark.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "3x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "idiom" : "universal",
+      "scale" : "3x"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/.../Assets.xcassets/Connected.imageset/5.png → ...tusConnected.imageset/StatusConnected.png b/.../Assets.xcassets/Connected.imageset/5.png → ...tusConnected.imageset/StatusConnected.png
diff --git a/Reconnect/Assets.xcassets/StatusConnected.imageset/StatusConnectedDark.png b/Reconnect/Assets.xcassets/StatusConnected.imageset/StatusConnectedDark.png
diff --git a/Reconnect/Assets.xcassets/StatusDisconnected.imageset/Contents.json b/Reconnect/Assets.xcassets/StatusDisconnected.imageset/Contents.json
@@ -0,0 +1,52 @@
+{
+  "images" : [
+    {
+      "filename" : "StatusDisconnected.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "filename" : "StatusDisconnectedDark.png",
+      "idiom" : "universal",
+      "scale" : "1x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "idiom" : "universal",
+      "scale" : "2x"
+    },
+    {
+      "idiom" : "universal",
+      "scale" : "3x"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "idiom" : "universal",
+      "scale" : "3x"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/...sets.xcassets/Disconnected.imageset/4.png → ...connected.imageset/StatusDisconnected.png b/...sets.xcassets/Disconnected.imageset/4.png → ...connected.imageset/StatusDisconnected.png
diff --git a/Reconnect/Assets.xcassets/StatusDisconnected.imageset/StatusDisconnectedDark.png b/Reconnect/Assets.xcassets/StatusDisconnected.imageset/StatusDisconnectedDark.png
diff --git a/Reconnect/ReconnectApp.swift b/Reconnect/ReconnectApp.swift
@@ -40,9 +40,9 @@ struct ReconnectApp: App {
                 .environment(applicationModel)
         } label: {
             if server.isConnected {
-                Image("Connected")
+                Image("StatusConnected")
             } else {
-                Image("Disconnected")
+                Image("StatusDisconnected")
             }
         }
 

diff --git a/graphics/status/StatusConnected.png b/graphics/status/StatusConnected.png
diff --git a/graphics/status/StatusConnectedDark.png b/graphics/status/StatusConnectedDark.png
diff --git a/graphics/status/StatusDisconnected.png b/graphics/status/StatusDisconnected.png
diff --git a/graphics/status/StatusDisconnectedDark.png b/graphics/status/StatusDisconnectedDark.png