Implement generic CLI query connection end #405
Conversation
| for RunQueryConnectionEndCommand | ||
| where | ||
| App: CanLoadBuilder<Builder = Build> | ||
| + CanProduceOutput<Counterparty::ConnectionEnd> |
There was a problem hiding this comment.
The connection end returned from CanQueryConnectionEnd is of type Chain::ConnectionEnd. So you need to use that to produce the CLI output.
| + CanRaiseError<String>, | ||
| Build: CanBuildChain<0, Chain = Chain> + HasChainTypeAt<1, Chain = Counterparty>, | ||
| Chain: CanQueryChainHeight + CanQueryConnectionEnd<Counterparty>, | ||
| Counterparty: HasHeightType + HasChainId + HasConnectionEndType<Chain>, |
There was a problem hiding this comment.
All the constraints for Counterparty are not really needed, thus can be removed.
| + CanParseArg<Args, symbol!("height"), Parsed = Option<Chain::Height>> | ||
| + CanRaiseError<Build::Error> | ||
| + CanRaiseError<Chain::Error> | ||
| + CanRaiseError<String>, |
There was a problem hiding this comment.
We didn't raise any string error in this implementation. So the constraint can be removed.
| + CanProduceOutput<Counterparty::ConnectionEnd> | ||
| + CanParseArg<Args, symbol!("chain_id"), Parsed = Chain::ChainId> | ||
| + CanParseArg<Args, symbol!("connection_id"), Parsed = Chain::ConnectionId> | ||
| + CanParseArg<Args, symbol!("height"), Parsed = Option<Chain::Height>> |
There was a problem hiding this comment.
We need to add the following wiring to HermesParserComponents to enable the parsing of the given fields.
(QueryConnectionEndArgs, symbol!("chain_id")): ParseFromString<ChainId>,
(QueryConnectionEndArgs, symbol!("connection_id")): ParseFromString<ConnectionId>,
(QueryConnectionEndArgs, symbol!("height")): ParseFromOptionalString<Height>,
| @@ -57,7 +54,7 @@ impl CommandRunner<HermesApp> for QueryCommands { | |||
| match self { | |||
| Self::Client(cmd) => app.run_command(cmd).await, | |||
| Self::Clients(cmd) => cmd.run(app).await, | |||
| Self::Connection(cmd) => cmd.run(app).await, | |||
| Self::Connection(cmd) => app.run_command(cmd).await, | |||
There was a problem hiding this comment.
We need to add the following wiring to HermesCommandRunnerComponents to forward the subcommand to the corresponding runners:
QueryConnectionSubCommand: RunQueryConnectionSubCommand,
QueryConnectionEndArgs: RunQueryConnectionEndCommand,
| height: Option<String>, | ||
| } | ||
|
|
||
| impl<App, Args, Build, Chain, Counterparty> CommandRunner<App, Args> |
There was a problem hiding this comment.
The following constraints should be added to CanUseHermesApp to check that the HermesApp context indeed implements CommandRunner for the corresponding command args:
+ CanRunCommand<QueryConnectionSubCommand>
+ CanRunCommand<QueryConnectionEndArgs>
| @@ -1,6 +1,3 @@ | |||
| mod connection; | |||
There was a problem hiding this comment.
The corresponding files at commands/query/connection should be removed.
Part of #393.
Description
Following the guideline in issue description to do it.
This PR is still in-draft but I have 1 question for you @soareschen. I'm getting this error:
I guess it relates to one of traits I used in
Chain&Counterpartywhen implementing forRunQueryConnectionEndCommandbut I still didn't figure out what's wrong in my implementation. Can you please point it out for me? Thanks.