Add Wasm variant of ibc-go v7 and v8 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soareschen
commented
Aug 26, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| nixConfig = { | |||
| substituters = "https://cosmos-nix.cachix.org https://cache.nixos.org https://nix-community.cachix.org"; | |||
| trusted-public-keys = "cosmosnix.store-1:O28HneR1MPtgY3WYruWFuXCimRPwY7em5s0iynkQxdk= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs="; | |||
| trusted-public-keys = "cosmos-nix.cachix.org-1:I9dmz4kn5+JExjPxOd9conCzQVHPl0Jo1Cdp6s+63d4= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs="; | |||
There was a problem hiding this comment.
The public key for the cosmos-nix Cachix is somehow wrong. So I am updating it. Source: https://app.cachix.org/cache/cosmos-nix
ljoss17
reviewed
Aug 26, 2024
flake.nix
Outdated
| type = "github"; | ||
| owner = "cosmos"; | ||
| repo = "ibc-go"; | ||
| ref = "modules/light-clients/08-wasm/v0.3.1%2Bibc-go-v7.4-wasmvm-v1.5"; |
There was a problem hiding this comment.
Shouldn't this be ibc go v8.4 with wasm?
Suggested change
| ref = "modules/light-clients/08-wasm/v0.3.1%2Bibc-go-v7.4-wasmvm-v1.5"; | |
| ref = "modules/light-clients/08-wasm/v0.4.1%2Bibc-go-v8.4-wasmvm-v2.0"; |
There was a problem hiding this comment.
Right, looks like I pasted the copied git tag to the wrong place. Should be fixed now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #220 and adds the latest Wasm variant of ibc-go v7 and v8: