Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix race condition in TestPartition_PrependLogFile_Write_Fail #25246

Draft
wants to merge 1 commit into
base: main-2.x
Choose a base branch
from

Conversation

gwossum
Copy link
Member

@gwossum gwossum commented Aug 14, 2024

Fix race condition in TestPartition_PrependLogFile_Write_Fail.

t.Cleanup(func() {
if err := p.Close(); err != nil {
t.Fatalf("error closing partition: %v", err)
}
})
p.Partition.MaxLogFileSize = -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. @gwossum - I should have mentioned to you before that I addressed this in one our internal repos with a fix. It's pr #57 - I'll slack you the link in slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants