Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update rust version #5505

Merged
merged 4 commits into from
Sep 9, 2024
Merged

build(deps): update rust version #5505

merged 4 commits into from
Sep 9, 2024

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Sep 9, 2024

Update the rust version to 1.72, this is the earliest version that can be linked to musl 1.2.4.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@mhilton mhilton self-assigned this Sep 9, 2024
@mhilton mhilton requested a review from a team as a code owner September 9, 2024 09:07
Update the libc dependency for libflux in order to build correctly
using musl-1.2.4.
@mhilton mhilton force-pushed the mh-fluxlib-update-libc branch 7 times, most recently from 81396cf to 45a94fe Compare September 9, 2024 11:07
Require rust version 1.72, this is the earliest version that can
build against musl 1.2.4.
@mhilton mhilton changed the title build(deps): update libflux libc dependency build(deps): update rust version Sep 9, 2024
Copy link

@solomonope solomonope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilton mhilton merged commit da19e08 into master Sep 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants