Improved Bubble Sort Algorithm #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
iluwatar
requested changes
Oct 6, 2024
|
|
||
| } while (!sorted); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add empty line at EOF to satisfy github
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: This new code improves the performance of the Bubble Sort Algorithm by a significant margin.
Problem: The earlier version of the Bubble Sort Code Snippet was taking a best case scenario of O(n^2) because the case where the array is already sorted was not being considered.
Improvements: The improved version of the code does the following things,
Correct Loop Structure: The nested loop structure has been revised to ensure proper sorting. The outer loop now uses a do-while construct, which iterates until the array is confirmed to be sorted thus reducing the time complexity if the array is already sorted. The inner loop handles the comparison and swapping of adjacent elements.
Early Termination: The implementation includes a sorted flag to allow the algorithm to terminate early if no swaps are made during a pass, indicating the array is already sorted. This optimization improves the best-case performance to O(n).
Reduced Range After Each Pass: The lastIndex variable is decremented after each pass to reduce the range of comparisons in subsequent iterations, as the largest elements bubble up to their correct positions.
Request: I would like to request to implement the proposed solution in the bubbleSort() function.