Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable trace for docker login. #285

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

falkzoll
Copy link
Contributor

Run the docker login in a subshell with disabled trace to avoid having credentials in the logs when trace is on (set -x).

Copy link
Contributor

@Luke-Roy-IBM Luke-Roy-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luke-Roy-IBM Luke-Roy-IBM merged commit 0f71b6a into ibm-functions:master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants