Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist on account level (cont.) #165

Merged

Conversation

steffenrost
Copy link

Blacklist on account level

Description

This code change enables the blacklisting on account level. By doing so invokes on all namespaces of the blacklisted account will be rejected (error: Unable to invoke action.. Too many requests in the last minute (count: 1, allowed: 0).)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #165 (b35ac2c) into master (7c9ec1b) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

❗ Current head b35ac2c differs from pull request most recent head d18d9fb. Consider uploading reports for the commit d18d9fb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   52.09%   52.07%   -0.02%     
==========================================
  Files         195      195              
  Lines        9867     9874       +7     
  Branches      495      620     +125     
==========================================
+ Hits         5140     5142       +2     
- Misses       4727     4732       +5     
Files Coverage Δ
...core/controller/BasicAuthenticationDirective.scala 100.00% <100.00%> (ø)
...he/openwhisk/core/invoker/NamespaceBlacklist.scala 71.42% <0.00%> (-11.91%) ⬇️

... and 8 files with indirect coverage changes

@steffenrost steffenrost force-pushed the sr-blacklist-by-account-2 branch 15 times, most recently from 3876f18 to d32e048 Compare October 3, 2023 09:04
Copy link

@teteich teteich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steffenrost steffenrost merged commit fc0d7ea into ibm-functions:master Oct 5, 2023
1 check passed
@steffenrost steffenrost deleted the sr-blacklist-by-account-2 branch October 5, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants