Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to also work with nodejs:20 as the default nodejs runtime. #164

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Allow tests to also work with nodejs:20 as the default nodejs runtime. #164

merged 1 commit into from
Sep 21, 2023

Conversation

falkzoll
Copy link

Allow tests to also work with nodejs:20 as the default nodejs runtime.

Description

Allow tests to also work with nodejs:20 as the default nodejs runtime.

Related issue and scope

  • none

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@falkzoll
Add nodejs:20, go:1.19 and go:1.21 to apiv1swagger and tests.
6a707bb 
- Use the pre installed docker inside the github action.
- Deploy openwhisk in single mode instead of HA mode to reduce the memory and disk requirements in the github action.
@codecov-commenter
Copy link

Codecov Report

Merging #164 (357d1ab) into master (03ce08c) will decrease coverage by 0.18%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 357d1ab differs from pull request most recent head e488287. Consider uploading reports for the commit e488287 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   52.25%   52.08%   -0.18%     
==========================================
  Files         195      195              
  Lines        9865     9867       +2     
  Branches      491      495       +4     
==========================================
- Hits         5155     5139      -16     
- Misses       4710     4728      +18
Files Changed Coverage Δ
...pache/openwhisk/core/invoker/InvokerReactive.scala 87.01% <100.00%> (+0.12%) ⬆️

... and 5 files with indirect coverage changes

Luke-Roy-IBM
Luke-Roy-IBM approved these changes Sep 21, 2023
View reviewed changes
Copy link

@Luke-Roy-IBM Luke-Roy-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@falkzoll falkzoll merged commit 7c9ec1b into ibm-functions:master Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Roy-IBM Luke-Roy-IBM Luke-Roy-IBM approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falkzoll @codecov-commenter @Luke-Roy-IBM