Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIGRATION.md migration guide #4

Closed
wants to merge 2 commits into from
Closed

Add MIGRATION.md migration guide #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9deb853
Add migration guide
iangmaia Feb 5, 2023
a201022
Update MIGRATION.md
iangmaia Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Release Toolkit Migration Guide

---

## Migrating to Trunk

### Considerations for breaking changes

- Ensure that calls to `ios_bump_version_release` already passed `skip_glotpress: true`.
In case of passing false as parameter or not providing a value (false being the default for this ConfigItem), you'll have to ensure that:
- `download_metadata.swift` isn't being used; if it is, it's a good time to migrate to the new tooling
- You're not relying on `ios_bump_version_release` for commiting the `.po/.pot` file
- The deprecated actions `ios_localize_project` and `ios_update_metadata` were now completely removed. If your project is still using it, please use the new tooling instead.
See `ios_generate_strings_file_from_code`, `ios_extract_keys_from_strings_files`, `ios_download_strings_files_from_glotpress` and `ios_merge_strings_files`.
iangmaia marked this conversation as resolved.
Show resolved Hide resolved

### Clean-ups

- You can now delete the `ENV['APP_STORE_STRINGS_FILE_NAME']` from your Fastfile, as it isn't being used anymore.