Skip to content

Commit

Permalink
Merge pull request #79 from kaleido-io/fix-browser-back
Browse files Browse the repository at this point in the history
use replaceIn param when setting query parameters
  • Loading branch information
shorsher authored Nov 23, 2021
2 parents 54a9605 + 0d23257 commit 8351002
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firefly-ui",
"version": "0.4.1",
"version": "0.4.2",
"private": true,
"dependencies": {
"@emotion/react": "^11.4.1",
Expand Down Expand Up @@ -73,4 +73,4 @@
"prettier": "^2.2.1"
},
"proxy": "http://localhost:5000"
}
}
2 changes: 1 addition & 1 deletion src/core/components/DataViewSwitch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const DataViewSwitch: React.FC = () => {
}

// use view from state and update the url
setView(dataView);
setView(dataView, 'replaceIn');
}, [view, setView, setDataView, dataView]);

return (
Expand Down
2 changes: 1 addition & 1 deletion src/core/components/DatePicker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const DatePicker: React.FC = () => {
}

// use time from state and update the url
setTime(createdFilter);
setTime(createdFilter, 'replaceIn');
}, [time, setTime, setCreatedFilter, createdQueryOptions, createdFilter]);

return (
Expand Down
2 changes: 1 addition & 1 deletion src/modules/data/views/Data/Data.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const Data: () => JSX.Element = () => {

useEffect(() => {
//set query param state
setFilterQuery(activeFilters);
setFilterQuery(activeFilters, 'replaceIn');
if (activeFilters.length === 0) {
setFilterString('');
return;
Expand Down
2 changes: 1 addition & 1 deletion src/modules/data/views/Messages/Messages.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export const Messages: () => JSX.Element = () => {

useEffect(() => {
//set query param state
setFilterQuery(activeFilters);
setFilterQuery(activeFilters, 'replaceIn');
if (activeFilters.length === 0) {
setFilterString('');
return;
Expand Down
2 changes: 1 addition & 1 deletion src/modules/data/views/Transactions/Transactions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const Transactions: () => JSX.Element = () => {

useEffect(() => {
//set query param state
setFilterQuery(activeFilters);
setFilterQuery(activeFilters, 'replaceIn');
if (activeFilters.length === 0) {
setFilterString('');
return;
Expand Down

0 comments on commit 8351002

Please sign in to comment.