Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a script for circuit compilation and verifier generation #27

Merged

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Aug 2, 2024

Add a bash script to automate what's documented for circuit compilation, verification key generation and verifier library generation.

The npm run gen script by default processes up to 10 (configurable) circuits in parallel which hugely reduce the dev cycle.

Signed-off-by: Chengxuan Xing <[email protected]>
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.09%. Comparing base (56b4652) to head (138a67b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   44.52%   45.09%   +0.56%     
==========================================
  Files          14       14              
  Lines         530      530              
==========================================
+ Hits          236      239       +3     
+ Misses        255      253       -2     
+ Partials       39       38       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jimthematrix jimthematrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Chengxuan! something that I've been wanting to do as well. will be super useful!

solidity/contracts/lib/verifier_check_nullifiers.sol Outdated Show resolved Hide resolved
zkp/generate.sh Outdated Show resolved Hide resolved
zkp/generate.sh Outdated Show resolved Hide resolved
zkp/generate.sh Outdated Show resolved Hide resolved
zkp/generate.sh Outdated Show resolved Hide resolved
zkp/generate.sh Outdated Show resolved Hide resolved
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
@Chengxuan
Copy link
Contributor Author

@jimthematrix thanks for the review comments. Switched the script to an NPM script with all comment addressed

Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
@jimthematrix jimthematrix merged commit 39bd365 into hyperledger-labs:main Aug 3, 2024
5 checks passed
@Chengxuan Chengxuan mentioned this pull request Aug 5, 2024
@Chengxuan Chengxuan deleted the propose-generate-script branch August 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants