Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load INC GPTQ checkpoint & rename params #1364

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

HolyFalafel
Copy link
Contributor

@HolyFalafel HolyFalafel commented Sep 26, 2024

Added load options for different GPTQ checkpoints.
Modified the load params accordingly

@yafshar
Copy link
Contributor

yafshar commented Sep 26, 2024

@HolyFalafel can you run the test ensuring your changes does not break anything else and provide the output before and after this PR?

make test_installs
RUN_SLOW=true GAUDI2_CI=1 python -m pytest tests/test_text_generation_example.py -v -s --token=....

examples/text-generation/README.md Outdated Show resolved Hide resolved
examples/text-generation/README.md Outdated Show resolved Hide resolved
@imangohari1
Copy link
Contributor

@HolyFalafel @yafshar
There is bug in this PR in Makefile.
a simple make test_installs doesn't work. I fixed it in the patch.
@hsubramony is going to push it to this PR.
0001-fix-pr1364-fixed-the-Makefile-indentation.patch

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

examples/text-generation/README.md Outdated Show resolved Hide resolved
examples/text-generation/utils.py Outdated Show resolved Hide resolved
Comment on lines +305 to +309
parser.add_argument(
"--run_partial_dataset",
action="store_true",
help="Run the inference with dataset for specified --n_iterations(default:5)",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used in this PR so I don't think it should be part of it. Please open a new PR to add this new argument to the text-generation example.

examples/text-generation/run_generation.py Outdated Show resolved Hide resolved
@regisss regisss changed the base branch from main to v1.14-release October 7, 2024 22:49
@regisss regisss merged commit f8bb4b2 into huggingface:v1.14-release Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants