feat(android): create a circleci config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on reviewing this. I am trying to run it with docker and having issues. |
|
Okay, this is ready for review. |
arriIsHere
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Sets up CircleCI integration for the Android SDK.
Short description of the changes
This is a standard Android CircleCI setup according to https://circleci.com/developer/orbs/orb/circleci/android
The only change I made was adding a trigger to make it run.
How to verify that this has the expected result
I don't know how to really test this other than to push it and see that the project/workflow shows up in CircleCI. Any other suggestions are appreciated. The
circleciCLI says the config is "valid":I tried to run it locally with the circleci cli, but apparently "machine" images aren't supported by the cli, and it couldn't download the image. I tried with a different image, but we'd have to do something hacky to start the emulator. So it's probably best to follow the recommended setup here.