Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing an await on dns.write_hosts call #4463

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

mdegat01
Copy link
Contributor

Proposed change

Missing an await in a call to plugin_dns.write_hosts

23-07-31 16:40:27 DEBUG (MainThread) [supervisor.homeassistant.websocket] Queuing message until startup has completed: {'type': <WSType.SUPERVISOR_EVENT: 'supervisor/event'>, 'data': {'event': <WSEve
/usr/src/supervisor/supervisor/addons/__init__.py:462: RuntimeWarning: coroutine 'PluginDns.write_hosts' was never awaited
  self.sys_plugins.dns.write_hosts()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Jul 31, 2023
@mdegat01 mdegat01 requested review from frenck and agners July 31, 2023 21:00
@frenck frenck merged commit 81ce0a6 into main Jul 31, 2023
23 checks passed
@frenck frenck deleted the fix-write-hosts-never-awaited branch July 31, 2023 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants