Add user-defined pre-delete hook annotation and labels for job #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benashz
reviewed
Jun 27, 2024
| @@ -141,6 +141,14 @@ controller: | |||
| # This value defines additional annotations for the deployment. This should be formatted as a YAML object (map) | |||
| annotations: {} | |||
|
|
|||
| # Controller pre-delete hook labels and annotations | |||
There was a problem hiding this comment.
It would be great if we could move the hooks configuration to
vault-secrets-operator/chart/values.yaml
Line 786 in 67fce39
benashz
reviewed
Jun 27, 2024
There was a problem hiding this comment.
This is looking good. We will need to add some tests for it, though. It would be good to move the configuration to the hooks specific values as well.
You can take a look at https://github.com/hashicorp/vault-secrets-operator/blob/main/test/unit/hook-upgrade-crds.bats for sample of what the tests might look like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for users to add annotations and labels on the
pre-deleteJob defined indeployment.yaml. This is particularly useful for when you are running the VSO operator in an istio sidecar enabled servicemesh, but would like to exclude the Job from getting an istio sidecar by adding istio-specific labels.