Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update github.com/dustinkirkland/golang-petname #581

Merged
merged 1 commit into from
May 21, 2024

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 21, 2024

Reference: #576

This update is proposed to remove some questionable words from the upstream generator. It is manually submitted because the dependency does not use semantic versioning and Dependabot sometimes has trouble with commit-based release update suggestions.

Reference: #576

This update is proposed to remove some questionable words from the upstream generator. It is manually submitted because the dependency does not use semantic versioning and Dependabot sometimes has trouble with commit-based release update suggestions.
@bflad bflad added this to the v3.7.0 milestone May 21, 2024
@bflad bflad requested a review from a team as a code owner May 21, 2024 18:37
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wonder if the 2.11 release was meant to be the start of module versioning, although I'm guessing it's not showing because of the lack of v prefix? 🤔

https://pkg.go.dev/github.com/dustinkirkland/golang-petname?tab=versions
https://github.com/dustinkirkland/golang-petname/releases/tag/2.11

@bflad
Copy link
Contributor Author

bflad commented May 21, 2024

wonder if the 2.11 release was meant to be the start of module versioning, although I'm guessing it's not showing because of the lack of v prefix

It might be some artifact about the downstream Debian package implementation or something, e.g. https://packages.debian.org/search?keywords=petname&searchon=names&suite=stable&section=all

@bflad bflad merged commit d9ff533 into main May 21, 2024
44 checks passed
@bflad bflad deleted the bflad/petnames-update branch May 21, 2024 19:16
@bflad bflad modified the milestones: v3.7.0, v3.6.2 May 21, 2024
bflad added a commit that referenced this pull request May 21, 2024
@bflad bflad mentioned this pull request May 21, 2024
bflad added a commit that referenced this pull request May 21, 2024
dduportal referenced this pull request in jenkins-infra/azure May 22, 2024
<Actions>
<action
id="296d75eab55b9d23bd1e94dc34cea43b964c29945c12fefcb674e3c068a0a767">
        <h3>Bump Terraform `random` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/random&#34; updated from
&#34;3.6.1&#34; to &#34;3.6.2&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.6.2</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-random/releases/tag/v3.6.2&#xA;NOTES:&#xA;&#xA;*
resource/random_pet: Results have been updated to the latest upstream
petname data
([#581](https://github.com/hashicorp/terraform-provider-random/issues/581))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/193/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants