Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consul_service resource documentation #352

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

remilapeyre
Copy link
Collaborator

Closes #350

@david-yu
Copy link
Contributor

david-yu commented Sep 8, 2023

Hi @remilapeyre does this need review?

@remilapeyre
Copy link
Collaborator Author

Hi @david-yu, yes a review would be appreciated :)

@remilapeyre
Copy link
Collaborator Author

Hi @david-yu, usually I wait for a review from another contributor before merging my pull requests but since this has been open for some time and is only touches the documentation I will merge now.

@remilapeyre remilapeyre merged commit 7ce8556 into hashicorp:master Oct 8, 2023
4 checks passed
@remilapeyre remilapeyre deleted the issue-350 branch October 8, 2023 19:26
remilapeyre added a commit to absolutelightning/terraform-provider-consul that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consul_service check_id isn't optional as documented in registry
2 participants