-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maximum_length to the user_settings set within aws_appstream_stack #39078
base: main
Are you sure you want to change the base?
Add maximum_length to the user_settings set within aws_appstream_stack #39078
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @EricZaporzan 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Type: nullable.TypeNullableInt, | ||
Optional: true, | ||
Default: "", | ||
ValidateFunc: nullable.ValidateTypeStringNullableIntBetween(1, 20971520), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got some doubt that I approached this schema addition correctly. It appears to work as expected (acceptance tests pass) but I'd appreciate advice on whether this was the right way to implement this. Here's an example of how it looks in the Terraform state
"user_settings": [
{
"action": "CLIPBOARD_COPY_FROM_LOCAL_DEVICE",
"maximum_length": "10000",
"permission": "ENABLED"
},
{
"action": "CLIPBOARD_COPY_TO_LOCAL_DEVICE",
"maximum_length": "1000000",
"permission": "ENABLED"
},
{
"action": "DOMAIN_PASSWORD_SIGNIN",
"maximum_length": "",
"permission": "ENABLED"
},
{
"action": "DOMAIN_SMART_CARD_SIGNIN",
"maximum_length": "",
"permission": "DISABLED"
},
{
"action": "FILE_DOWNLOAD",
"maximum_length": "",
"permission": "DISABLED"
},
{
"action": "FILE_UPLOAD",
"maximum_length": "",
"permission": "ENABLED"
},
{
"action": "PRINTING_TO_LOCAL_DEVICE",
"maximum_length": "",
"permission": "DISABLED"
}
]
Description
Allowing for the setting of maximum_length in user_settings for AppStream stacks.
Relations
N/A
References
https://aws.amazon.com/about-aws/whats-new/2024/02/amazon-appstream-2-0-controls-limiting-clipboard/
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appstream-stack-usersetting.html#aws-properties-appstream-stack-usersetting-properties
Output from Acceptance Testing