Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up, setting maintaining team to Consul #1792

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

roncodingenthusiast
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast commented Aug 9, 2023

  • setup golangci lint
  • updates to slack and notification channels
  • adding a make command for linting

- clean up dependencies
- adding golangci lint
- updating maintaining teams
- allow release/** to build newer versions of consul-template going forward
@roncodingenthusiast roncodingenthusiast merged commit 5935938 into main Oct 4, 2023
54 checks passed
@roncodingenthusiast roncodingenthusiast deleted the issue-1767 branch October 4, 2023 15:36
release_branches = ["main"]
release_branches = [
"main",
"release/**",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of adding the release/** here?

@@ -72,3 +72,9 @@ toc:
dev-tree:
@true
.PHONY: dev-tree

# lint
lint:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@@ -68,7 +68,3 @@ require (
golang.org/x/time v0.3.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/golang/lint => golang.org/x/lint v0.0.0-20190409202823-959b441ac422

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why we had these replace directives before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants