Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15772 upgrade to gradle 8.4 #16141

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

valenad1
Copy link
Collaborator

@valenad1 valenad1 commented Apr 6, 2024

Part of #15772

I am running it on nightly: http://jenkins:8080/view/H2O-3/job/h2o-3-nightly-pipeline/job/valenad-GH-15772-upgrade-to-gradle-8-4/4/

and it seem good, in terms of the current jenkins conditions. I would like to merge to master rather than directly to rel-*

@valenad1 valenad1 force-pushed the valenad-GH-15772-upgrade-to-gradle-8-4 branch from dd1830b to c81bf08 Compare April 12, 2024 12:19
@valenad1 valenad1 requested a review from mn-mikke April 12, 2024 12:22
@valenad1 valenad1 assigned krasinski and unassigned krasinski Apr 12, 2024
@valenad1 valenad1 requested a review from krasinski April 12, 2024 12:22
@valenad1 valenad1 force-pushed the valenad-GH-15772-upgrade-to-gradle-8-4 branch 4 times, most recently from 4f8d2a9 to bc79e03 Compare April 22, 2024 15:41
@@ -78,6 +73,17 @@ dependencies {
api(project(":h2o-parquet-parser")) {
transitive = false
}

constraints {
api("org.apache.hadoop:hadoop-client:$hadoopMavenArtifactVersion")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that the hadoop artifacts are the same after this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a very good point - those were not the same, that option didn't force
I pushed a new version - there are still some strange differences, but stuff like guava is forced firmly at 20.0
overall that kind of comparison I think we need to do also for other stuff

@valenad1 valenad1 force-pushed the valenad-GH-15772-upgrade-to-gradle-8-4 branch from 9b8e433 to 6d9f394 Compare May 9, 2024 15:09
@valenad1 valenad1 force-pushed the valenad-GH-15772-upgrade-to-gradle-8-4 branch from 6d9f394 to 4dafffc Compare May 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants