Skip to content

Commit

Permalink
Setup dependabot (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
ViridianForge authored Sep 12, 2024
1 parent eec2790 commit d2ed7d6
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
version: 2
updates:
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: "chore(deps):"
commit-prefix: "dependabot"
labels:
- "dependencies"
4 changes: 4 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ jobs:
pip install -e .
pip install -r requirements-test.txt
pip install protobuf==${{ matrix.protobuf-version }}
if [ "${{ matrix.protobuf-version }}" = "4.25.4" ]; then
pip install grpcio==1.65.5
pip install grpcio-reflection==1.65.5
fi
- name: Test with pytest
run: |
pytest --cov-report=xml --cov=src/grpc_requests
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ For protobuf, we target versions that in their public support phase.
[Python's support matrix](https://devguide.python.org/versions/)
[Protobuf's support matrix](https://protobuf.dev/support/version-support/#python)

### Protobuf Compatibility

The maintainers of `grpc_requests` have found that protobuf `4.25.4` is not compatible
with verisons `>=1.66.0` of both `grpcio` and `grpcio-reflection`. If your use case
needs `4.25.4` of protobuf, we recommend sticking to verison `1.65.x` of `grpcio` and
`grpcio-reflection`.

## Questions, Comments, Issues?

For questions, please start a conversation on the [discussions page](https://github.com/wesky93/grpc_requests/discussions)!
Expand Down
5 changes: 5 additions & 0 deletions noxfile.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import nox


@nox.session
@nox.parametrize(
"python,protobuf",
Expand All @@ -12,6 +13,10 @@
def test(session, protobuf):
session.install("-e",".")
session.install("-r", "requirements-test.txt")
# grpcio after version 1.65 is not compatible with protobuf 4.25.4
if protobuf == "4.25.4":
session.install("grpcio==1.65.5")
session.install("grpcio-reflection==1.65.5")
session.install(f"protobuf=={protobuf}")
session.run("pytest")

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
grpcio >= 1.60.1
grpcio-reflection >= 1.60.1
protobuf>=3.20.3
protobuf>=4.25.0
google-api-core>=2.11.1
cryptography>=41.0.7

0 comments on commit d2ed7d6

Please sign in to comment.