Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate inclusion binding threshold and add new --aggregate-inclusion-count-limit parameter #1147

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from

Conversation

susannasiebert
Copy link
Contributor

@susannasiebert susannasiebert commented Sep 13, 2024

This PR fixes an issue we recently discovered where using the --allele-specific-binding-thresholds parameter would not use the --aggregate-inclusion-binding-threshold but instead fall back on selecting entries to be included based on the --binding-threshold as the cutoff. With this PR, the --aggregate-inclusion-binding-threshold will now also be respected/used, even if the --allele-specific-binding-thresholds is set.

However after fixing this bug we discovered that it leads to a large number of peptide candidates being included with the default cutoff of 5000 (particularly for frameshift variants), exceeding GitHub file size limits for the pVACview demo data (specifically, the metrics file) and slowness when loading the data in pVACview.

To solve this, this PR also adds a new parameter --aggregate-inclusion-count-limit (default: 15) which, for variants exceeding 15 peptides passing the --aggregate-inclusion-binding-threshold, will limit the included entries to those of the 15 best peptides (as defined by our algorithm for selecting the best peptide per variant).

By limiting the number of peptides included for each variant, there are less outliers with a large number of candidates. This previously resulted in us limiting the number of candidates displayed in the pVACview anchor heatmap. With this update, this limitation has been removed and all included peptides candidates are now shown in the anchor heatmap.

@susannasiebert susannasiebert marked this pull request as ready for review September 13, 2024 14:26
@susannasiebert susannasiebert marked this pull request as draft September 16, 2024 17:40
@susannasiebert
Copy link
Contributor Author

susannasiebert commented Sep 16, 2024

TODO:

  • Update all example data
  • Update documentation to document new parameter and new column
  • Update pVACview screenshots used in documentation and tutorial showing aggregated report

@susannasiebert susannasiebert marked this pull request as ready for review September 23, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant