Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define abstract Mutation.mutate() method [type-hints] #1393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Define abstract Mutation.mutate() method [type-hints] #1393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions graphene/types/mutation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ def __init_subclass_with_meta__(
)
arguments = props(input_class) if input_class else {}
if not resolver:
mutate = getattr(cls, "mutate", None)
assert mutate, "All mutations must define a mutate method in it"
resolver = get_unbound_function(mutate)
resolver = get_unbound_function(cls.mutate)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that with current implementation it's really needed to call get_unbound_function() instead of just referring cls.mutate. Should I check it?

if _meta.fields:
_meta.fields.update(fields)
else:
Expand All @@ -117,6 +115,10 @@ def __init_subclass_with_meta__(
_meta.arguments = arguments

super(Mutation, cls).__init_subclass_with_meta__(_meta=_meta, **options)

@classmethod
def mutate(cls, parent, info, **kwargs):
raise NotImplementedError("All mutations must define a mutate method in it")

@classmethod
def Field(
Expand Down
Loading