Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify making token by byte position, not rune position at readName #605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nktks
Copy link

@nktks nktks commented Jun 9, 2021

Hi!

I tried to parse SDL with multibyte comment , and failed.

I think, the cause is that the start and end positions of the token created in readName were created as the rune position.
If the comment contains a multibyte character string, the start and end of the token shifts from the actual byte position, and it seems that the token is not parsed correctly.

Please review this.

Thanks!

@coveralls
Copy link

coveralls commented Jun 9, 2021

Coverage Status

Coverage remained the same at 92.422% when pulling ea0716e on nakatamixi:fix/multi-byte-parse into 8a92e97 on graphql-go:master.

@nktks nktks changed the title modify make token by byte position, not rune position at readName modify making token by byte position, not rune position at readName Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants