Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore light/dark custom setting #9716

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Restore light/dark custom setting #9716

merged 3 commits into from
Oct 16, 2024

Conversation

aliabid94
Copy link
Collaborator

Restores the ability to set the light / dark theme via:

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/fcb0f6ba174f373ef67acf478c4057582fa93f5b/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@fcb0f6ba174f373ef67acf478c4057582fa93f5b#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/fcb0f6ba174f373ef67acf478c4057582fa93f5b/gradio-client-1.6.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/fcb0f6ba174f373ef67acf478c4057582fa93f5b/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Restore light/dark custom setting

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton added t: fix A change that implements a fix v: patch A change that requires a patch release labels Oct 15, 2024
Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both SSR and CSR modes!

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I tested on Spaces as well. LGTM, will merge in

@abidlabs abidlabs merged commit 3c7f2ad into main Oct 16, 2024
20 of 22 checks passed
@abidlabs abidlabs deleted the restore_lightdark_url branch October 16, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants