-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add texture-compression-bc-sliced-3d
#4763
Add texture-compression-bc-sliced-3d
#4763
Conversation
Previews, as seen when this build job started (0047db9): |
Co-authored-by: Kai Ninomiya <[email protected]>
Co-authored-by: Kai Ninomiya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggested changes I think this will be ready to land.
Co-authored-by: Kai Ninomiya <[email protected]>
Co-authored-by: Kai Ninomiya <[email protected]>
Co-authored-by: Kai Ninomiya <[email protected]>
Co-authored-by: Kai Ninomiya <[email protected]>
@kainino0x thank you very much for the suggestions, I believe that with reverts and clarifications, the extension as in PR is got better not only for itself but as a template for ASTC Sliced 3D and beyond. However, I'd like to consult for just a few matters:
TYVM! |
2: Looks good to me |
LGTM, thank you! |
GPU Web WG 2024-07-24 Atlantic-time
|
Fixes #4705
This PR makes base BCn extension 2D only, and requires the bc-sliced-3d extension to allow 3D dimension for BCn textures as sliced 3D.
This extension requires base bc extension, so I tried to phrase it in a succinct way. Please let me know if that would benefit from any improvement.
TYVM!