Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation tests for 3D textures with compression #3762

Merged
merged 2 commits into from
May 28, 2024

Conversation

mehmetoguzderin
Copy link
Member

@mehmetoguzderin mehmetoguzderin commented May 26, 2024

Fixes #3761

It has been a little while since I had a closer look at CTS. Please let me know if I missed or overlooked anything. Your guidance would be appreciated. Thank you!


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, forgot we had a bunch of tests here already. LGTM

@kainino0x kainino0x enabled auto-merge (squash) May 28, 2024 22:21
@kainino0x kainino0x changed the title Update tests for 3D textures with compression Update validation tests for 3D textures with compression May 28, 2024
@kainino0x kainino0x merged commit c92608b into gpuweb:main May 28, 2024
1 check passed
kainino0x added a commit that referenced this pull request May 30, 2024
kainino0x added a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test texture-compression-bc-sliced-3d
2 participants